fixes #370 -- epsilon search would crash when root node in leaf list #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Errors in tests seem to be from tests that need to be updated. |
|
apologies, I never saw this comment; I'll get to it shortly |
|
Just to be clear -- you should have an invitation to have commit rights to this repository, so if you are happy with this PR you are welcome to merge it yourself. I am more than happy to be called on for review, but I would also be very happy if you want to manage these yourself. See https://github.com/scikit-learn-contrib/hdbscan/invitations in case the invitation got lost somehow. |
|
Oh, thanks for posting. I didn't see that before; will merge. I thought that test failure was my doing, but it appears to be that way in master. |
…t node in leaf list
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented discussion with @cmalzer #370 (comment)
fixes example code originally provided by @danielzgtg
epsilon search was working with allow_single_cluster except in the case where eom_clusters contained the root node, which was passed in as a leaf.
Now if using 'eom', 'allow_single_cluster', and 'cluster_selection_epsilon' , the root node is returned as the selected cluster if it is the only cluster in the eom_clusters list.