Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the package #43

Closed
5 tasks done
glemaitre opened this issue May 14, 2016 · 4 comments
Closed
5 tasks done

Refactor the package #43

glemaitre opened this issue May 14, 2016 · 4 comments

Comments

@glemaitre
Copy link
Member

glemaitre commented May 14, 2016

Hi,

I would go for a long run and refactor the package such that it follows more the scikit-learn template.
What I mean by that is something like this.

I propose to add the following support:

  • sphinx/numpy doc.
  • proper testing.
  • continuous integration via Travis. If somebody wants to do the AppVeyor, that could be nice but I don't have interest in that.
  • refactor the package into modules.
  • proper coverage.

The full package will actually benefit from it. On the user side with a proper documentation. On the developer side to ensure back compatibility.

I will probably open a pull-request for that. It might be taking a while, but if anybody wants to jump in, I would be happy.

@fmfn
Copy link
Collaborator

fmfn commented May 17, 2016

I really like the idea. As the package gets used more and more some of its bugs are surfacing and proper testing and documentation would go a long way in fixing that.

@glemaitre
Copy link
Member Author

@fmfn Could you create a branch gh-pages. I can make the pull request of the documentation branch there : http://glemaitre.github.io/UnbalancedDataset/

The page needs some improvements but this is a start

@fmfn
Copy link
Collaborator

fmfn commented May 22, 2016

fmfn added a commit that referenced this issue May 22, 2016
[MRG] Refactoring the toolbox, see issue #43
@glemaitre
Copy link
Member Author

Adressed in PR #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants