FIX InstanceHardnessThreshold accepts classifier included in a Pipeline #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the option to add a pipeline as an estimator for instance hardness threshold. Currently using a pipeline as an estimator fails because of the instance check. I think it's useful to be able to use pipelines as estimators and have thus added it.
fixed the silly mistake
|
The linter is failing. Could you add a non-regression test that would fail in |
glemaitre
changed the title
glemaitre
added a commit
that referenced
this pull request
Mar 31, 2024
…ne (#1049) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to add a pipeline as an estimator for instance hardness threshold. Currently using a pipeline as an estimator fails because of the instance check. I think it's useful to be able to use pipelines as estimators and have thus added it.
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?