Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] EHN Add a FunctionSampler #342

Merged
merged 24 commits into from Feb 17, 2018

Conversation

glemaitre
Copy link
Member

Reference Issue

related to #9360 in scikit-learn bug tracker

What does this implement/fix? Explain your changes.

Any other comments?

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #342 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #342      +/-   ##
=========================================
+ Coverage   98.77%   98.8%   +0.02%     
=========================================
  Files          67      69       +2     
  Lines        3926    4001      +75     
=========================================
+ Hits         3878    3953      +75     
  Misses         48      48
Impacted Files Coverage Δ
imblearn/tests/test_misc.py 100% <100%> (ø)
imblearn/utils/estimator_checks.py 96% <100%> (+0.14%) ⬆️
imblearn/misc.py 100% <100%> (ø)
imblearn/tests/test_common.py 94.73% <0%> (-0.72%) ⬇️
imblearn/over_sampling/adasyn.py 98.5% <0%> (ø) ⬆️
imblearn/_version.py 100% <0%> (ø) ⬆️
imblearn/ensemble/classifier.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3877493...792c29d. Read the comment docs.

@chkoar
Copy link
Member

chkoar commented Nov 1, 2017

What's the status of this? Can we maintain the coverage and merge it?

@glemaitre
Copy link
Member Author

I have to check why the sampler is complaining. I think that I should also add a gallery example and the documentation.

@glemaitre
Copy link
Member Author

@chkoar We need to find a better location for this than misc. We need to find a name related to user usage rather than developer naming.

@glemaitre
Copy link
Member Author

As we mentioned earlier, we can use this for fast prototyping a new balancing method or getting a bit off topic and use it to make any sampling type (resampling) and use it in pipeline.

@glemaitre glemaitre changed the title [WIP] EHN Add a FunctionSampler [MRG] EHN Add a FunctionSampler Dec 1, 2017
@glemaitre
Copy link
Member Author

@chkoar @massich This is almost good to be merged. We need to decide a nice name for the submodule.

@chkoar
Copy link
Member

chkoar commented Dec 7, 2017

We need to decide a nice name for the submodule.

This is the most difficult part of this PR.

@glemaitre
Copy link
Member Author

what about custom?

@glemaitre
Copy link
Member Author

or customized

@glemaitre
Copy link
Member Author

I think that the proposition to make it available at root is the best:

from imblearn import FunctionSampler

@glemaitre glemaitre merged commit d482829 into scikit-learn-contrib:master Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants