New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] EHN Add a FunctionSampler #342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=========================================
+ Coverage 98.77% 98.8% +0.02%
=========================================
Files 67 69 +2
Lines 3926 4001 +75
=========================================
+ Hits 3878 3953 +75
Misses 48 48
Continue to review full report at Codecov.
|
What's the status of this? Can we maintain the coverage and merge it? |
I have to check why the sampler is complaining. I think that I should also add a gallery example and the documentation. |
@chkoar We need to find a better location for this than misc. We need to find a name related to user usage rather than developer naming. |
As we mentioned earlier, we can use this for fast prototyping a new balancing method or getting a bit off topic and use it to make any sampling type (resampling) and use it in pipeline. |
This is the most difficult part of this PR. |
what about |
or |
I think that the proposition to make it available at root is the best: from imblearn import FunctionSampler |
Reference Issue
related to #9360 in scikit-learn bug tracker
What does this implement/fix? Explain your changes.
Any other comments?