New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: random sampler can sample from heterogeneous data #451

Merged
merged 7 commits into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@glemaitre
Member

glemaitre commented Aug 23, 2018

closes #429

@pep8speaks

This comment has been minimized.

pep8speaks commented Aug 23, 2018

Hello @glemaitre! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 23, 2018 at 12:58 Hours UTC

glemaitre added some commits Aug 23, 2018

@codecov

This comment has been minimized.

codecov bot commented Aug 23, 2018

Codecov Report

Merging #451 into master will decrease coverage by 0.03%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   98.78%   98.75%   -0.04%     
==========================================
  Files          75       75              
  Lines        4446     4492      +46     
==========================================
+ Hits         4392     4436      +44     
- Misses         54       56       +2
Impacted Files Coverage Δ
imblearn/ensemble/base.py 96.15% <100%> (ø) ⬆️
imblearn/combine/smote_enn.py 100% <100%> (ø) ⬆️
...otype_selection/tests/test_random_under_sampler.py 100% <100%> (ø) ⬆️
imblearn/combine/smote_tomek.py 100% <100%> (ø) ⬆️
...mpling/prototype_selection/random_under_sampler.py 100% <100%> (ø) ⬆️
...rn/over_sampling/tests/test_random_over_sampler.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/random_over_sampler.py 100% <100%> (ø) ⬆️
imblearn/utils/validation.py 99.39% <75%> (-0.61%) ⬇️
imblearn/utils/estimator_checks.py 96.76% <95.83%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cd9a6...5539a72. Read the comment docs.

glemaitre added some commits Aug 23, 2018

@glemaitre glemaitre merged commit 6916fe9 into scikit-learn-contrib:master Aug 23, 2018

1 of 4 checks passed

LGTM analysis: Python Running analyses for revisions
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment