Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Compatibility with sklearn 1.0 #864

merged 17 commits into from Sep 29, 2021


Copy link

Solve issue with the current CI.

Copy link

pep8speaks commented Sep 28, 2021

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 764:17: W503 line break before binary operator

Line 1301:5: W503 line break before binary operator
Line 1303:9: W503 line break before binary operator
Line 1304:9: W503 line break before binary operator

Comment last updated at 2021-09-29 10:27:03 UTC

@glemaitre glemaitre changed the title MNT be compatible with scikit-learn 1.0 MNT Compatibility with sklearn 1.0 Sep 28, 2021
Copy link
Member Author

We should probably remove PEP8speaks

Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #864 (b602022) into master (edf6eae) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head b602022 differs from pull request most recent head c43d99f. Consider uploading reports for the commit c43d99f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
+ Coverage   98.69%   98.86%   +0.16%     
  Files          93       93              
  Lines        6063     6060       -3     
  Branches      508      508              
+ Hits         5984     5991       +7     
+ Misses         78       68      -10     
  Partials        1        1              
Impacted Files Coverage Δ
imblearn/ensemble/tests/ 100.00% <ø> (ø)
imblearn/ensemble/tests/ 100.00% <ø> (ø)
imblearn/metrics/ 96.34% <ø> (ø)
imblearn/metrics/tests/ 100.00% <ø> (ø)
imblearn/over_sampling/_smote/ 100.00% <ø> (ø)
imblearn/over_sampling/tests/ 100.00% <ø> (ø)
...rn/over_sampling/tests/ 100.00% <ø> (ø)
imblearn/tests/ 100.00% <ø> (ø)
...ototype_generation/tests/ 100.00% <ø> (ø)
..._selection/tests/ 100.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf6eae...c43d99f. Read the comment docs.

@glemaitre glemaitre merged commit f407976 into scikit-learn-contrib:master Sep 29, 2021
glemaitre added a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants