[MRG] Fix test for components_from_metric and add tests for _check_sdp_from_eigen #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdevazelhes
requested review from
bellet,
perimosocordiae and
terrytangyuan
and removed request for
perimosocordiae,
terrytangyuan and
bellet
bellet
approved these changes
Aug 3, 2020
|
There are just some linting errors to fix before we can merge |
|
All CIs are green, merging |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
See #264 (comment)
This PR fixes the test that was failing
test_components_from_metric_edge_cases, and at the same time tests better_check_sdp_from_eigen