Add a link to CircleCI documentation on keys

[arokem]

No description provided.

[coveralls]

Coverage remained the same at 100.0% when pulling 37b6678 on arokem:patch-1 into 5b72257 on scikit-learn-contrib:master.

[arokem]

Might need even more documentation, considering that CircleCi does not take encrypted keys. Still working on that :-)

[arokem]

OK. This might be enough.

[coveralls]

Coverage remained the same at 100.0% when pulling b90197f on arokem:patch-1 into 5b72257 on scikit-learn-contrib:master.

[vighneshbirodkar]

The formatting could be a little better. Also to be consistent with the rest of the documentation, it would be better if we had a named link here, for eg:
[Circle CI documentation on ssh keys](...url...)

[arokem]

Thanks for the feedback. How's this?

[vighneshbirodkar]

@arokem Thanks for your contribution.My only concern here is that from the method currently suggested ( going to Project settings and clicking on "Create and add user key"), there is no way to add add a password protected key.

I think a better way to put it would be :

Follow these instructions if you want to [manually add an SSH key](...url...) and make sure they key isn't password protected.

My point is that a novice user should not be confused by these instructions if the CircleCI web gui can do it for him/her.

[coveralls]

Coverage remained the same at 100.0% when pulling 9790a3f on arokem:patch-1 into 5b72257 on scikit-learn-contrib:master.

[arokem]

On Thu, May 12, 2016 at 11:05 AM, Vighnesh Birodkar <
notifications@github.com> wrote:

@arokem https://github.com/arokem Thanks for your contribution.My only
concern here is that from the method currently suggested ( going to Project
settings and clicking on "Create and add user key"), there is no way to add
add a password protected key.

Do you mean "from the method currently suggested ( going to Project
settings and clicking on "Create and add user key"), there is no way to add
a key that is not password protected"? That's the thing that led me to
this PR. CircleCI couldn't commit to the gh-pages branch, because the thing
that happens per default is that a password-protected key is generated.
You need to follow the instructions on that CircleCI documentation page,
but particularly, when you follow the link through to this page:
https://help.github.com/articles/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent/,
you would need to skip through step 4 without generating a password
(simply pressing [Enter] twice would do it), for it to actually work.

The question is: how do we best communicate that?

I think a better way to put it would be :

Follow these instructions if you want to manually add an SSH key and make sure they key isn't password protected.

My point is that a novice user should not be confused by these
instructions if the CircleCI web gui can do it for him/her.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#19 (comment)

[vighneshbirodkar]

@arokem The currently suggested method adds keys which are not password protected. Moreover, it never asks for the password. I say that because that's what I did and it worked.

How did you create SSH keys ?

[arokem]

TBH, I don't remember. I think that I tried to follow the instructions
here, and that it led to me having a password protected key, but maybe I am
wrong and this patch isn't necessary? You can close it for now.

On Thu, May 12, 2016 at 11:44 AM, Vighnesh Birodkar <
notifications@github.com> wrote:

@arokem https://github.com/arokem The currently suggested method adds
keys which are not password protected. Moreover, it never asks for the
password. I say that because that's what I did and it worked.

How did you create SSH keys ?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#19 (comment)