Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Adding Appveyor CI #22

Merged
merged 1 commit into from
Sep 3, 2016
Merged

[MRG] Adding Appveyor CI #22

merged 1 commit into from
Sep 3, 2016

Conversation

vighneshbirodkar
Copy link
Member

Addresses #14

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3780858 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8319825 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f8f1445 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f8f1445 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4c5e9fd on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0cf911c on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 53ba556 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 18b85df on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 26ba71a on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ddcb3bf on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@vighneshbirodkar vighneshbirodkar changed the title [WIP] Adding Appveyor CI [MRG] Adding Appveyor CI May 14, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 00664e2 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@vighneshbirodkar
Copy link
Member Author

@fabianp @mblondel @MechCoder Can you have a look ?

fabianp
fabianp reviewed May 14, 2016
View reviewed changes
ci_scripts/appveyor/install.ps1
}


function DownloadMiniconda ($python_version, $platform_suffix) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is used plus appveyor now has miniconda installed by default

@fabianp
Copy link
Member

fabianp commented May 14, 2016

Hey. Thanks for working on this. I believe it is correct but the appveyor install script might be unnecessarily complicated. Now appveyor has miniconda pre-installed so there is no need to install the Python official version. Using miniconda has the added benefit that it is possible to build conda packages (this is how we build lightning conda win packages)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e38d2d2 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4f73a82 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 47474af on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db49450 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@vighneshbirodkar
Added appveyor support
01c3ba8 
added appveyor files from sklearn

added apveyor file

corrected path

removed sklearn logo link

Fixed nosetest command

removed unnecessary hooks

Added debug command

escape quotes properly

Added nosetests command

make nose more verbose

increase verbosity by one more

Build wheel

Added build wheel command

Add missing quote

add debug ls commands

escape back slashes

add __init__ file in tests to make tests importable

remove erronous ls

remove debug commands and add nosetest config

appveyor upload wheels

and the unvisersal flag

corrected flag ordering

Remove universal flag

Moved CI files to specific folders

wip appveyor text in readme

move hardcoded values to env variables

Add missing quote

switch to backward slash

escaped backslash

removed find links option

add forward slash

Added PROJECT_NAME variable

Added Appveyor description

Readme corrections

Try with appveyor conda

Install nose-timer via pip

remove pip install

Removed unnecessary appveyor files
@vighneshbirodkar
Copy link
Member Author

@fabianp Have a look now. I am not yet building conda recipes. I prefer to leave that to a different PR

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 01c3ba8 on vighneshbirodkar:appv into 5da57b3 on scikit-learn-contrib:master.

@fabianp
Copy link
Member

fabianp commented May 20, 2016

Awesome, +1 from me

@vighneshbirodkar
Copy link
Member Author

@MechCoder Please have a look.

@vighneshbirodkar
Copy link
Member Author

@mblondel Could you review this ? It already has one +1

@MechCoder
Copy link
Contributor

@lesteve might be the right person to ping for issues like these.

@lesteve
Copy link

lesteve commented Jul 22, 2016

@lesteve might be the right person to ping for issues like these.

From a quick look at it, this looks good to me. Full disclosure I have never written something like this from scratch but rather always looked at what scikit-learn was doing and adapted it for other projects. I am guessing this is what you have done as well.

@vighneshbirodkar
Copy link
Member Author

@fabianp Can you merge this ? @lesteve also gave it an OK

@fabianp
Copy link
Member

fabianp commented Sep 3, 2016

Great, merging

@fabianp fabianp merged commit 1ef32a0 into scikit-learn-contrib:master Sep 3, 2016
@jnothman jnothman mentioned this pull request Jul 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vighneshbirodkar @coveralls @fabianp @MechCoder @lesteve