enforcing most recent build of scikit-learn #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also update the version in Why is that that the documentation needs a separate requirements.txt? It would be nice if it could use the same dependency already declared in |
rosecers
force-pushed
the
enforce-recent-sklearn
branch
from
d57c1d9
to
6aef8c2
Compare
|
@Luthaf updated the docs/requirements. Any thoughts on the failing tests? |
|
Looks like the project on pypi is not called sklearn but scikit-learn: https://pypi.org/project/sklearn/ points to https://pypi.org/project/scikit-learn/ |
rosecers
force-pushed
the
enforce-recent-sklearn
branch
from
6aef8c2
to
d3b8525
Compare
Luthaf
reviewed
Feb 10, 2021
setup.cfg
Outdated
| @@ -16,7 +16,7 @@ include_package_data = True | |||
| zip_safe = True | |||
| packages = find: | |||
| install_requires = numpy | |||
| sklearn | |||
| sklearn>="0.24.0" | |||
There was a problem hiding this comment.
We should also change this one =)
sklearn added an arpack initializer in 0.24.0 that was previously unavailable.
rosecers
force-pushed
the
enforce-recent-sklearn
branch
from
d3b8525
to
599eb8d
Compare
Luthaf
approved these changes
Feb 10, 2021
|
It looks like we lost code coverage status though =/ |
What do you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sklearn added an arpack initializer in 0.24.0 that was previously unavailable.