Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH - implement intercept update for Poisson and Gamma datafits #189

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

mathurinm
Copy link
Collaborator

closes #137

@Badr-MOUFAD can you check the math?

@mathurinm mathurinm mentioned this pull request Oct 6, 2023
skglm/datafits/single_task.py Outdated Show resolved Hide resolved
skglm/datafits/single_task.py Outdated Show resolved Hide resolved
@Badr-MOUFAD Badr-MOUFAD changed the title WIP intercept gamma ENH - implement intercept update for Poisson and Gamma datafits Oct 9, 2023
Co-authored-by: Badr MOUFAD <65614794+Badr-MOUFAD@users.noreply.github.com>
@mathurinm
Copy link
Collaborator Author

@Badr-MOUFAD merge if OK

Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Badr-MOUFAD Badr-MOUFAD merged commit 6376620 into scikit-learn-contrib:main Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants