Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] ENH - add working set strategy to group_bcd_solver #28

Merged
merged 25 commits into from Jun 11, 2022
Merged

[READY] ENH - add working set strategy to group_bcd_solver #28

merged 25 commits into from Jun 11, 2022

Conversation

Badr-MOUFAD
Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD commented Jun 3, 2022 •
edited

This continues #26

It will proceed as follows

  • Implement working sets
  • Benchmark against main branch

@Badr-MOUFAD
Copy link
Collaborator Author

I did some benchmarks, thanks to benchopts, against the main branch which doesn't implement working set strategy

Here are my results:

Results for alpha / alpha_max = 0.1

rho=01

Results for alpha / alpha_max = 0.01

rho001

Results for alpha / alpha_max = 0.001

rho0001

@mathurinm @PABannier, shall we proceed forward to adding Anderson acceleration?

@Badr-MOUFAD Badr-MOUFAD changed the title [WIP] ENH - add working set strategy to group_bcd_solver [READY] ENH - add working set strategy to group_bcd_solver Jun 8, 2022
@Badr-MOUFAD Badr-MOUFAD mentioned this pull request Jun 8, 2022
Merged
2 tasks
@mathurinm
Copy link
Collaborator

Can you add unit tests ?

PABannier
PABannier reviewed Jun 8, 2022
View reviewed changes
skglm/solvers/group_bcd_solver.py Outdated Show resolved Hide resolved
skglm/solvers/group_bcd_solver.py Outdated Show resolved Hide resolved
skglm/solvers/group_bcd_solver.py Show resolved Hide resolved
skglm/solvers/group_bcd_solver.py Show resolved Hide resolved
skglm/solvers/group_bcd_solver.py Show resolved Hide resolved
PABannier
PABannier approved these changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@PABannier PABannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor cosmetic, LGTM

skglm/penalties/block_separable.py Show resolved Hide resolved
@mathurinm mathurinm merged commit 9929e71 into scikit-learn-contrib:main Jun 11, 2022
@mathurinm
Copy link
Collaborator

Thanks @Badr-MOUFAD :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PABannier PABannier PABannier approved these changes

@mathurinm mathurinm mathurinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Badr-MOUFAD @mathurinm @PABannier