Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API transform solver functions into classes #63

Merged
merged 87 commits into from
Sep 13, 2022
Merged

API transform solver functions into classes #63

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
4dc9f20
transform prox newton into a solver
mathurinm Aug 29, 2022
d7b83cb
Merge branch 'main' of github.com:scikit-learn-contrib/skglm into sol…
mathurinm Aug 31, 2022
2c9f953
WIP cd solver
PABannier Aug 31, 2022
84cfaa0
try solver
PABannier Aug 31, 2022
0f469b3
linter happy
PABannier Aug 31, 2022
44e5b3c
intialize df
mathurinm Aug 31, 2022
715f4cb
WIP generalized Linear estimator
PABannier Aug 31, 2022
d62e18a
WIP
PABannier Aug 31, 2022
8928c1c
WIP estimators
PABannier Sep 1, 2022
bf8784c
CLN rest of estimators
PABannier Sep 1, 2022
058d94c
lint
PABannier Sep 1, 2022
8215ca7
Update skglm/estimators.py
PABannier Sep 1, 2022
1b216ef
changed to _glm_fit
PABannier Sep 1, 2022
a847b59
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier Sep 1, 2022
cc0ac81
a -> an
PABannier Sep 1, 2022
d92f292
refactor GramCD
PABannier Sep 1, 2022
fc5d488
cln estimators
PABannier Sep 1, 2022
803d357
some fixes for doc
mathurinm Sep 1, 2022
2fe0360
model passed to solver.solve, fit_intercept as attribute of model
mathurinm Sep 1, 2022
1aeaeab
warm_start
PABannier Sep 1, 2022
993b5b1
warm_start 2
PABannier Sep 1, 2022
7f06be0
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier Sep 1, 2022
d47f0a9
FIX tests
PABannier Sep 1, 2022
92a2b80
fix more tests
PABannier Sep 1, 2022
b765d4d
fixed test_prox_newton
PABannier Sep 1, 2022
5ff9945
fix test datafits
PABannier Sep 1, 2022
1402a16
fix gram tests
PABannier Sep 1, 2022
74cd022
prox newton
mathurinm Sep 1, 2022
1d36882
changed signature of solver.solve
PABannier Sep 1, 2022
9817dda
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier Sep 1, 2022
61f7370
solver.solve harmonized
PABannier Sep 1, 2022
6c1b026
added tol to estimators (except GLE)
PABannier Sep 1, 2022
b373bce
fix
PABannier Sep 1, 2022
214b195
test groups fixed
PABannier Sep 1, 2022
840010d
fixed some other tests
PABannier Sep 1, 2022
99eb5bc
added MTL solver
PABannier Sep 1, 2022
8cf7be7
lint
PABannier Sep 1, 2022
b0c8fcb
added warm start
PABannier Sep 1, 2022
486f6af
better namings of files
PABannier Sep 1, 2022
831dea0
fix linting
PABannier Sep 1, 2022
80a3ca0
changed to PN for defaut solver in logreg
PABannier Sep 1, 2022
c6326b5
fix some bugs
PABannier Sep 1, 2022
5706695
Merge branch 'main' of github.com:scikit-learn-contrib/skglm into sol…
mathurinm Sep 1, 2022
998fe6a
fix signature path mtl
PABannier Sep 1, 2022
980c6aa
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier Sep 1, 2022
5531131
rm warm_start and fit_intercept from GLE
mathurinm Sep 1, 2022
9b79388
Merge branch 'solver_class' of github.com:mathurinm/skglm into solver…
mathurinm Sep 1, 2022
9e68bee
some fixes
mathurinm Sep 1, 2022
8950736
fix some docstrings
mathurinm Sep 1, 2022
5729aec
fix Lasso test, design is not the best
mathurinm Sep 1, 2022
2c754ab
exposes attributes to estimators
PABannier Sep 2, 2022
83e1034
passing test estimators
PABannier Sep 2, 2022
bc3421d
fixed MTL tests
PABannier Sep 2, 2022
f524a31
fix return_n_iter
PABannier Sep 2, 2022
226bf61
added xfail for fit intercept in PN
PABannier Sep 2, 2022
4c6521d
remove fit_intercept from SVC
PABannier Sep 2, 2022
318d968
linter almost happy
PABannier Sep 2, 2022
2e38382
tests are passing
PABannier Sep 2, 2022
9b9b7f1
Update skglm/estimators.py
PABannier Sep 2, 2022
67ebeba
Update skglm/estimators.py
PABannier Sep 2, 2022
eb3bc5d
_solver -> solver'
PABannier Sep 2, 2022
95b7c93
remove solver from docstring
PABannier Sep 2, 2022
2c1c13f
removed path
PABannier Sep 2, 2022
2d656ae
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier Sep 2, 2022
c1c6976
remove noqa
PABannier Sep 2, 2022
e6a035f
revert
PABannier Sep 2, 2022
b46521e
docs building
PABannier Sep 2, 2022
fd38917
docs building 2
PABannier Sep 2, 2022
fcfa0ea
exposed p0, tol, max_iter, etc...
PABannier Sep 2, 2022
4220c1e
linter ok
PABannier Sep 2, 2022
3fb5ef1
fix pydocstyle
PABannier Sep 2, 2022
4220ae3
revert __init__
PABannier Sep 2, 2022
ddb0174
fix docstring
PABannier Sep 2, 2022
115437c
l
PABannier Sep 2, 2022
436de98
green?
PABannier Sep 2, 2022
d054b8c
ADD base solver
PABannier Sep 2, 2022
ec43d36
green
PABannier Sep 2, 2022
43b333a
Merge branch 'solver_class' of github.com:mathurinm/skglm into solver…
mathurinm Sep 8, 2022
7e9664d
Merge branch 'main' of github.com:scikit-learn-contrib/skglm into sol…
mathurinm Sep 8, 2022
9e9e1e4
rename to AndersonCD solver, remove try_solver.py
mathurinm Sep 8, 2022
38bf792
CLN
mathurinm Sep 8, 2022
0cee34a
rename accelerated_cd.py to anderson_cd.py
mathurinm Sep 8, 2022
ad77737
Update skglm/solvers/prox_newton.py
mathurinm Sep 9, 2022
84be3fa
exchange path and solve order in MTL
mathurinm Sep 9, 2022
c480523
fix bug intercept in AndersonCD
Badr-MOUFAD Sep 12, 2022
baf2f56
illustrative comment in gram_solver
Badr-MOUFAD Sep 12, 2022
ab6bab1
linter happy
Badr-MOUFAD Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading