Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Typo and path highlight bug #23

Merged

Conversation

jwaton
Copy link
Contributor

@jwaton jwaton commented Dec 21, 2018

Two very small fixes:

  • One typo fix in the README.md file of the word 'complementary'
  • One conditional execution in stability selection plot; in the case where all paths were highlighted, this code would error on line 139 (plotting non-highlighted paths). There is an argument for saying then the regularisation parameter search range is not appropriate, but we can avoid the error by adding an if statement.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 76

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 97.368%

Totals Coverage Status
Change from base Build 75: 0.007%
Covered Lines: 370
Relevant Lines: 380

💛 - Coveralls

@thuijskens thuijskens merged commit 695e526 into scikit-learn-contrib:master Jan 19, 2019
@thuijskens
Copy link
Collaborator

Good catch! Thanks very much for the contribution, and apologies for only looking at this now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants