Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for sparse label matrix in coverage_error. #11348

Open
elanmart opened this issue Jun 23, 2018 · 3 comments
Open

Adding support for sparse label matrix in coverage_error. #11348

elanmart opened this issue Jun 23, 2018 · 3 comments

Comments

@elanmart
Copy link

Currently the implementation of sklearn.metrics.coverage_error expects dense indicator matrix for ground-truth labels (code)

Do you think it could be beneficial to extend it to support sparse matrices for y_true as well?

I could open a PR, as I needed this functionality in my personal project.

@jnothman
Copy link
Member

jnothman commented Jun 23, 2018 via email

@elanmart
Copy link
Author

I'd argue that it's a natural choice to keep y_true as a sparse matrix. And if a user chooses to do so, she can still use coverage_error without expensive calls to .toarray()

@jnothman
Copy link
Member

jnothman commented Jun 24, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants