We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In _find_best_bin_to_split_helper(), it'd be more efficient to only compute the (negative) loss of the parent once, instead of at each bin.
_find_best_bin_to_split_helper()
In other terms, we should compute negative_loss(sum_gradients, sum_hessians, l2_regularization)
negative_loss(sum_gradients, sum_hessians, l2_regularization)
before the for loop.
for
link to relevant code
I don't expect this to be a terrific improvement though.
Marking this easy, but I would not recommend as a first issue since it involves cython.
The text was updated successfully, but these errors were encountered:
Taking a look at this...was having trouble finding a test suite around the cython file though.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
In
_find_best_bin_to_split_helper()
, it'd be more efficient to only compute the (negative) loss of the parent once, instead of at each bin.In other terms, we should compute
negative_loss(sum_gradients, sum_hessians, l2_regularization)
before the
for
loop.link to relevant code
I don't expect this to be a terrific improvement though.
Marking this easy, but I would not recommend as a first issue since it involves cython.
The text was updated successfully, but these errors were encountered: