Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In histogram GBDTs, the parent node negative loss should be computed only once #13931

Closed
NicolasHug opened this issue May 23, 2019 · 1 comment · Fixed by #13955
Closed

In histogram GBDTs, the parent node negative loss should be computed only once #13931

NicolasHug opened this issue May 23, 2019 · 1 comment · Fixed by #13955
Labels
Easy Well-defined and straightforward way to resolve

Comments

@NicolasHug
Copy link
Member

NicolasHug commented May 23, 2019

In _find_best_bin_to_split_helper(), it'd be more efficient to only compute the (negative) loss of the parent once, instead of at each bin.

In other terms, we should compute
negative_loss(sum_gradients, sum_hessians, l2_regularization)

before the for loop.

link to relevant code

I don't expect this to be a terrific improvement though.

Marking this easy, but I would not recommend as a first issue since it involves cython.

@NicolasHug NicolasHug added Easy Well-defined and straightforward way to resolve help wanted labels May 23, 2019
@fhoang7
Copy link
Contributor

fhoang7 commented May 27, 2019

Taking a look at this...was having trouble finding a test suite around the cython file though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
2 participants