Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] MAINT warn of future behaviour change proposed in #2610 #2952

Merged
merged 1 commit into from
Apr 7, 2014

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Mar 9, 2014

Assuming my proposal in #2610 to make PRF's labels parameter more functional and deprecate pos_label goes through at some future point, it will create a compatibility issue in the case where all of the following apply:

  • y_true and y_pred contain at most two labels
  • labels specifies exactly two labels
  • pos_label is not None (default)
  • average is not None (generally default).

I expect this case is rare atm, but since behaviour would change with #2610 or similar (unless labels changed its name), we can warn in this release (0.15) and change behaviour in 0.16 or 0.17.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 28c8d0b on jnothman:future_warn_two_labels into 6091d7d on scikit-learn:master.

@agramfort
Copy link
Member

sklearn/linear_model/cd_fast.c is modified in this PR

@jnothman
Copy link
Member Author

sklearn/linear_model/cd_fast.c is modified in this PR

It was removed immediately after posting.

@jnothman jnothman added this to the 0.15 milestone Mar 11, 2014
@ogrisel
Copy link
Member

ogrisel commented Mar 20, 2014

+1 on my side.

@ogrisel ogrisel changed the title [MRG] MAINT warn of future behaviour change proposed in #2610 [MRG+1] MAINT warn of future behaviour change proposed in #2610 Mar 20, 2014
@arjoly
Copy link
Member

arjoly commented Apr 1, 2014

Looks good +1

@jnothman
Copy link
Member Author

jnothman commented Apr 7, 2014

I guess this should be merged, and then the real changes come after the release.

@jnothman jnothman changed the title [MRG+1] MAINT warn of future behaviour change proposed in #2610 [MRG+2] MAINT warn of future behaviour change proposed in #2610 Apr 7, 2014
jnothman added a commit that referenced this pull request Apr 7, 2014
MAINT warn of future behaviour change proposed in #2610
@jnothman jnothman merged commit d954846 into scikit-learn:master Apr 7, 2014
@jnothman jnothman deleted the future_warn_two_labels branch April 7, 2014 22:26
@amueller amueller modified the milestones: 0.16, 0.15 Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants