-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate descent should work on float32 data (in addition to float64 data) #5464
Comments
Use of cython in coordinate descent module make the type flexibility a bit
tricky, but should be doable.
We need to use fused types for this (read on cython fused types).
|
Float16 is too low: BLAS does not support it. But float32 (in addition to float64) is a good idea. BLAS comes in 2 flavors (for operations on real numbers as in non-complex): single precision (float32) and double precision (float64). The single precision operation are prefixed with |
I can work on this, if noone is already! |
Sure, but we need to remove c files from the repository before, so as not
|
Oh the idea is to make the build script generate c from pyx files locally instead of them being the repository? [Sorry, if there was a discussion but I missed it] |
Yes, checkout PR #5492. Still WIP ! |
@MechCoder but you can work on it independently. We just need #5492 be done before merging this. I didn't realize you could do |
Hello @MechCoder , |
For large scale application, constraining
ElasticNet
input to befloat64
is a waste of space, as same quality results should be obtainable withfloat32
or eventfloat16
input.Use of cython in coordinate descent module make the type flexibility a bit tricky, but should be doable.
The text was updated successfully, but these errors were encountered: