[MRG+2] fix #5269: Overflow error with sklearn.datasets.load_svmlight #7101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olologin
changed the title
| @@ -312,6 +312,9 @@ Bug fixes | |||
| (`#5460 https://github.com/scikit-learn/scikit-learn/pull/5460>`_) | |||
| By `Tom Dupre la Tour`_. | |||
|
|
|||
| - :func:`datasets.load_svmlight_file` now is able to read long int QID values. | |||
| By `Ibraim Ganiev`_. | |||
There was a problem hiding this comment.
maybe put a link to the PR?
There was a problem hiding this comment.
@nelson-liu Yes, you are right.
|
Thanks |
|
@jnothman , Oh, finally. Thank you too :) |
|
No problem, thanks for nagging. On 3 August 2016 at 13:56, Ganiev Ibraim notifications@github.com wrote:
|
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
…d_svmlight (scikit-learn#7101) * fix for scikit-learn#5269, overflow error * test with long qid added * What's new section added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like previous branch is somehow corrupted, created new branch and applied patches. Previous review #5580.
Fix #5269.
svmlight implementation uses long data type to read and store qid, so i think it makes sense to do same in scikit-learn implementation.