New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] fix #5269: Overflow error with sklearn.datasets.load_svmlight #7101

Merged
merged 3 commits into from Aug 3, 2016

Conversation

Projects
None yet
3 participants
@olologin
Contributor

olologin commented Jul 28, 2016

Looks like previous branch is somehow corrupted, created new branch and applied patches. Previous review #5580.

Fix #5269.

svmlight implementation uses long data type to read and store qid, so i think it makes sense to do same in scikit-learn implementation.

@olologin olologin changed the title from [MRG] fix #5269: Overflow error with sklearn.datasets.load_svmlight to [MRG+2] fix #5269: Overflow error with sklearn.datasets.load_svmlight Jul 30, 2016

@@ -312,6 +312,9 @@ Bug fixes
(`#5460 https://github.com/scikit-learn/scikit-learn/pull/5460>`_)
By `Tom Dupre la Tour`_.
- :func:`datasets.load_svmlight_file` now is able to read long int QID values.
By `Ibraim Ganiev`_.

This comment has been minimized.

@nelson-liu

nelson-liu Aug 1, 2016

Contributor

maybe put a link to the PR?

This comment has been minimized.

@olologin

olologin Aug 2, 2016

Contributor

@nelson-liu Yes, you are right.

@jnothman jnothman merged commit 928f724 into scikit-learn:master Aug 3, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jnothman

This comment has been minimized.

Member

jnothman commented Aug 3, 2016

Thanks

@olologin

This comment has been minimized.

Contributor

olologin commented Aug 3, 2016

@jnothman , Oh, finally. Thank you too :)

@jnothman

This comment has been minimized.

Member

jnothman commented Aug 3, 2016

No problem, thanks for nagging.

On 3 August 2016 at 13:56, Ganiev Ibraim notifications@github.com wrote:

@jnothman https://github.com/jnothman , Oh, finally. Thank you too :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7101 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6_rk7YLAMH4bQAfNqted6nFATJ4vks5qcBFtgaJpZM4JW9Fo
.

TomDLT added a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016

[MRG] fix scikit-learn#5269: Overflow error with sklearn.datasets.loa…
…d_svmlight (scikit-learn#7101)

* fix for scikit-learn#5269, overflow error

* test with long qid added

* What's new section added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment