Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI build broken at master #8010

Closed
jnothman opened this issue Dec 8, 2016 · 10 comments
Closed

CircleCI build broken at master #8010

jnothman opened this issue Dec 8, 2016 · 10 comments

Comments

@jnothman
Copy link
Member

@jnothman jnothman commented Dec 8, 2016

Exception occurred:
  File "/home/ubuntu/scikit-learn/doc/sphinxext/sphinx_gallery/docs_resolv.py", line 48, in _get_data
    with open(url, 'r') as fid:
IOError: [Errno 2] No such file or directory: '/home/ubuntu/scikit-learn/doc/_build/html/stable/modules/generated/sklearn.feature_selection.SelectKBest.rst.html'
The full traceback has been saved in /tmp/sphinx-err-ip4Xhn.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
Embedding documentation hyperlinks in examples..
	processing: feature_stacker.html
make: *** [html] Error 1

I don't understand how this came about, let alone why it might possibly result from merging #7938.

@jnothman
Copy link
Member Author

@jnothman jnothman commented Dec 8, 2016

It could have something to do with a change in how exit codes are propagated from #7938, but I still don't see how. :-\

@jnothman
Copy link
Member Author

@jnothman jnothman commented Dec 8, 2016

Perhaps we should revert that merge and investigate further?? Might have something to do with make dist

@amueller
Copy link
Member

@amueller amueller commented Dec 8, 2016

I was like "this can not possible make the CI fail, let's not wait for it" WRONG! Damn it.

@lesteve
Copy link
Member

@lesteve lesteve commented Dec 9, 2016

Might have something to do with make dist

from the log you posted make html seems the culprit instead, right?

make: *** [html] Error 1

For the record I can run make html fine locally and I don't understand the error message that happens in sphinx-gallery ... Maybe @Titan-C if you have a suggestion off the top of your head ...

Also the error was not fixed by reverting #7938, so that does not make to be related to this commit.

@lesteve
Copy link
Member

@lesteve lesteve commented Dec 9, 2016

Hmmm actually this may be related to sphinx-gallery/sphinx-gallery#137.

@lesteve
Copy link
Member

@lesteve lesteve commented Dec 9, 2016

So the problem is due to a change in sphinx 1.5 that breaks sphinx-gallery. I could reproduce the failure locally with sphinx 1.5.

I pushed a commit into master to use sphinx=1.4 on CircleCI, this should fix it.

@amueller
Copy link
Member

@amueller amueller commented Dec 9, 2016

So push #7938 again?

@lesteve
Copy link
Member

@lesteve lesteve commented Dec 9, 2016

The build on CircleCI https://circleci.com/gh/scikit-learn/scikit-learn/7602 has succeeded building the html and is now building the pdf.

So push #7938 again?

Yes

@jnothman
Copy link
Member Author

@jnothman jnothman commented Dec 15, 2016

So I assume we should hold on closing this until we include a fix from sphinx-gallery

@lesteve
Copy link
Member

@lesteve lesteve commented Dec 15, 2016

Actually this one should be closed. We are using sphinx=1.4 for now and the CircleCI on master is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.