CircleCI build broken at master

[jnothman]

Exception occurred:
  File "/home/ubuntu/scikit-learn/doc/sphinxext/sphinx_gallery/docs_resolv.py", line 48, in _get_data
    with open(url, 'r') as fid:
IOError: [Errno 2] No such file or directory: '/home/ubuntu/scikit-learn/doc/_build/html/stable/modules/generated/sklearn.feature_selection.SelectKBest.rst.html'
The full traceback has been saved in /tmp/sphinx-err-ip4Xhn.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
Embedding documentation hyperlinks in examples..
	processing: feature_stacker.html
make: *** [html] Error 1

I don't understand how this came about, let alone why it might possibly result from merging #7938.

[jnothman]

It could have something to do with a change in how exit codes are propagated from #7938, but I still don't see how. :-\

[jnothman]

Perhaps we should revert that merge and investigate further?? Might have something to do with make dist

[amueller]

I was like "this can not possible make the CI fail, let's not wait for it" WRONG! Damn it.

[lesteve]

Might have something to do with make dist

from the log you posted make html seems the culprit instead, right?

make: *** [html] Error 1

For the record I can run make html fine locally and I don't understand the error message that happens in sphinx-gallery ... Maybe @Titan-C if you have a suggestion off the top of your head ...

Also the error was not fixed by reverting #7938, so that does not make to be related to this commit.

[lesteve]

Hmmm actually this may be related to sphinx-gallery/sphinx-gallery#137.

[lesteve]

So the problem is due to a change in sphinx 1.5 that breaks sphinx-gallery. I could reproduce the failure locally with sphinx 1.5.

I pushed a commit into master to use sphinx=1.4 on CircleCI, this should fix it.

[amueller]

So push #7938 again?

[lesteve]

The build on CircleCI https://circleci.com/gh/scikit-learn/scikit-learn/7602 has succeeded building the html and is now building the pdf.

So push #7938 again?

Yes

[jnothman]

So I assume we should hold on closing this until we include a fix from sphinx-gallery

[lesteve]

Actually this one should be closed. We are using sphinx=1.4 for now and the CircleCI on master is fine.