-
-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG + 2] CI Report likely-affected documentation files #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope to see results at http://scikit-learn.org/circle?7364/_changed.html |
It seems to work, well done! |
That currently only appears in the build log. It's easy enough to copy to
the HTML
…On 25 November 2016 at 21:38, Tom Dupré la Tour ***@***.***> wrote:
It seems to work, well done!
Where does The following documentation files may have been changed by ...
is supposed to appear?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7938 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz62bCaF01-hBhx1OdSnTOb4oLiMa3ks5rBrqOgaJpZM4K8DQv>
.
|
looks neat. I don't like adding more shell scripts though ... +.5 |
You'd accept it if the first line of the script was '#!/usr/bin/env
python'?!
…On 1 December 2016 at 08:56, Andreas Mueller ***@***.***> wrote:
looks neat. I don't like adding more shell scripts though ... +.5
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7938 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6_4shhXsEc7R9SBv97wCLVJosSvCks5rDfEHgaJpZM4K8DQv>
.
|
I wouild ;) |
ha! well... I'm not rewriting it.
…On 2 December 2016 at 08:31, Andreas Mueller ***@***.***> wrote:
I wouild ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7938 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz69REKmbOV1j6P9q2XcqjmitH43OCks5rDzy0gaJpZM4K8DQv>
.
|
working with git commands is much easier in bash
…On 2 December 2016 at 14:07, Joel Nothman ***@***.***> wrote:
ha! well... I'm not rewriting it.
On 2 December 2016 at 08:31, Andreas Mueller ***@***.***>
wrote:
> I wouild ;)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#7938 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAEz69REKmbOV1j6P9q2XcqjmitH43OCks5rDzy0gaJpZM4K8DQv>
> .
>
|
4 tasks
amueller
changed the title
CI Report likely-affected documentation files
[MRG + 1] CI Report likely-affected documentation files
Dec 6, 2016
That will simplify the reviews :). Thanks. |
amueller
changed the title
[MRG + 1] CI Report likely-affected documentation files
[MRG + 2] CI Report likely-affected documentation files
Dec 7, 2016
jnothman
force-pushed
the
affected-doc
branch
from
December 7, 2016 22:51
7ca681a
to
64ba7cc
Compare
foo removed. |
Merged
jnothman
pushed a commit
that referenced
this pull request
Dec 9, 2016
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to make the changed documentation from a PR still more accessible as rendered, this reports a list of doc pages that were most likely affected by the PR. It is reported in the build logs and at a page
http://scikit-learn.org/circle?{BUILD_ID}/_changed.html
.Affected files are presumed to be:
doc/...rst
->.html
examples/...py
->auto_*.html
This last may under-generate in cases of class inheritance (not sure?).
It may over-generate where:
this over-generation could be fixed by more specific tracking of which source lines correspond to docstrings for which classes/functions... but probably later.