Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n_components parameter unused in linkage_tree #9307

Closed
jnothman opened this issue Jul 9, 2017 · 2 comments · Fixed by #9309
Closed

n_components parameter unused in linkage_tree #9307

jnothman opened this issue Jul 9, 2017 · 2 comments · Fixed by #9309
Labels
Easy Well-defined and straightforward way to resolve

Comments

@jnothman
Copy link
Member

jnothman commented Jul 9, 2017 •
edited

sklearn/cluser/hierarchical.py:linkage_tree accepts an undocumented n_components parameter, which it does not use. It should be removed, perhaps with deprecation.

H/T lgtm.com via https://github.com/lgtmhq/lgtm-queries/issues/14
@jnothman jnothman added Easy Well-defined and straightforward way to resolve Need Contributor labels Jul 9, 2017
@jnothman jnothman mentioned this issue Jul 9, 2017
Merged
@sharanry
Copy link
Contributor

Hey! Can I work on this?

@sharanry sharanry mentioned this issue Jul 10, 2017
Merged
@jnothman
Copy link
Member Author

jnothman commented Jul 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG+1] - DeprecationWarning for n_components parameter for linkage_tree sharanry/scikit-learn
3 participants
@jnothman @amueller @sharanry