[WIP] Catch deprecation warnings of random_state in svc tests #10222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch deprecation warning of svc random_state in tests.
jnothman
reviewed
Nov 29, 2017
sklearn/svm/tests/test_sparse.py
Outdated
| sp_clf = svm.OneClassSVM(kernel=kernel, random_state=0) | ||
| check_svm_model_equal(clf, sp_clf, *dataset) | ||
| with ignore_warnings(category=DeprecationWarning): | ||
| clf = svm.OneClassSVM(kernel=kernel, random_state=0) |
There was a problem hiding this comment.
nah. Just remove the use of random_state instead. It's never done anything, and the deprecation is checked elsewhere.
Removing 'random_state = 0' while intializing OneClassSVM object. (This doesn't have any effect on functionality)
|
@jnothman Thanks for the advice. In recent commit, I've removed the random_state parameter. I would also look for its use in /doc and /examples. |
|
Let me open a new pull request. In this one, there are a lot of other changes as well which I did for syncing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Reference Issue: #10158
Hi.. Regarding issue #10158, this PR is related to catching deprecation warnings of random_state in SVC tests.
I've found the following tests where the relevant deprecation warnings are raising.
scikit-learn/sklearn/svm/tests/test_sparse.py
Line 264 in 57bcd07
In this PR, the above test is edited to catch deprecation warning.
As for now, I've kept this PR '[WIP]' as there is need to make sure wether random_state is not being used in \examples or \doc.