MRG renamed min_n and max_n parameters in CountVectorizer
#1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for merge |
|
Thanks for the review @agramfort :). @ogrisel as you are our NLP expert and probably know the most about this module, I'd love to have your vote, too, if you find the time. |
|
Looks good to me too except that I find |
|
Yeah, |
|
+1 for |
|
Done. Thanks for the feedback. |
|
@ogrisel If you think this is ok, feel free to press the green button ;) |
| @@ -77,6 +77,10 @@ API changes summary | |||
| necessary for early-stopping in which case the tree is not | |||
| completely built. | |||
|
|
|||
| - In :class:`feature_extraction.text.CountVectorizer` the parameters | |||
| ``min_n`` and ``max_n`` were joined to the parameter ``bounds_n`` to | |||
|
+1 for merging once the too previous comments have been addressed. +1 for explicit parameter names in general :) |
|
merged by rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make grid-searching them together possible.
cc @agramfort and @ogrisel