added description for classes_ in the logistic documentation #12795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amueller |
|
Please merge master into your branch. |
|
You can run |
sklearn/linear_model/logistic.py
Outdated
| @@ -1178,6 +1178,13 @@ class LogisticRegression(BaseEstimator, LinearClassifierMixin, | |||
| Attributes | |||
| ---------- | |||
|
|
|||
| classes_ : array or shape (n_classes, ) | |||
There was a problem hiding this comment.
from looking at other examples, I am guessing it should be:
array, shape (n_classes, )
Is that correct?
There was a problem hiding this comment.
IMO array, shape ... or list, shape ...
sklearn/linear_model/logistic.py
Outdated
| classes_ : array or shape (n_classes, ) | ||
| A list of class labels known to the classifier. | ||
|
|
||
| In binary classification, one class is usually considered the |
There was a problem hiding this comment.
Why do you add this paragraph? I don't think we need it here.
There was a problem hiding this comment.
I can remove this entire sentence:
In binary classification, one class is usually considered the 'positive' class. For example, in labels [-1, 1], 1 is the positive class.
|
Also add it in LogisticRegressionCV? |
sklearn/linear_model/logistic.py
Outdated
| @@ -1503,6 +1506,9 @@ class LogisticRegressionCV(LogisticRegression, BaseEstimator, | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| classes_ : array, shape (n_classes, ) | |||
| @@ -1643,6 +1646,8 @@ class LogisticRegressionCV(LogisticRegression, BaseEstimator, | |||
|
|
|||
| Attributes | |||
| ---------- | |||
| classes_ : array, shape (n_classes, ) | |||
| A list of class labels known to the classifier. | |||
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 17, 2018
…essionCV documentation (scikit-learn#12795)
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Jan 7, 2019
…essionCV documentation (scikit-learn#12795)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…essionCV documentation (scikit-learn#12795)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…sticRegressionCV documentation (scikit-learn#12795)" This reverts commit 1b5a6c7.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…sticRegressionCV documentation (scikit-learn#12795)" This reverts commit 1b5a6c7.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
…essionCV documentation (scikit-learn#12795)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing PR / Issue
This closes #12219
Note
added classes_ to logistic regression documentation (logistic.py)
cc: @blooraspberry
#wimlds