Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
FIX Remove bins whose width <= 0 with a warning in KBinsDiscretizer #13165
Similar to #12893, I don't think it's the duty of a preprocessor to remove redundant features.
I think this is a bug (seems that Joel agrees with me in the issue), so we don't need to worry about backward compatibility.
referenced this pull request
Feb 19, 2019
No, not really. Regardless, I think this is an improvement on the status-quo anyway; and I don't think we test these boundary cases in other similar situations.
Feb 20, 2019
11 checks passed
Please open an issue if you think it's worth discussing. Honestly I'm unable to fully understand your point :)