New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+2] Minimize the validation of X in adaboost #13174
Merged
jnothman
merged 25 commits into
scikit-learn:master
from
chkoar:minimize_validation_in_meta_estimators
Feb 28, 2019
Merged
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9332837
Minimize validation of X
88118ab
One more iteration
a52af10
Update docstrings
2f07c55
Pass common tests
fe06a6c
add back the removed tests
110249d
Always convert to csr or csc
0a0a0c3
last changes
59d0944
Fix tests
ceae5fe
Add _num_samples
cb51fd6
fix pep8
7c728f9
fix test
2e9a045
Revert back docstrings and data_validation
5178572
pep8
03adc18
Update whats_new/v0.21.rst
a6ffe4b
pep8
daf7b7a
Check prediction
d0c62f6
Check prediction again
1713475
Address agramfort comments
3a07a37
Fix data generation
bdd6a24
fix validation [ci skip]
1efc196
Change strategy for DummyClassifier
e5ccc53
User relative imports
e6bf9ab
fix whats_new
5f9fc61
Address jnothman comment
1a2e896
Remove white space
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep lines under 80 characters