Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogisticRegression convert to float64 (for SAG solver) #13243

Merged
merged 31 commits into from Feb 27, 2019
Merged

LogisticRegression convert to float64 (for SAG solver) #13243

merged 31 commits into from Feb 27, 2019

Commits on Jul 8, 2018

  1. Remove unused code

    @massich @NelleV
    massich authored and NelleV committed Jul 8, 2018
    Copy the full SHA
    c4e223f View commit details
    Browse the repository at this point in the history

  2. Squash all the PR 9040 commits 

    initial PR commit

seq_dataset.pyx generated from template

seq_dataset.pyx generated from template #2

rename variables

fused types consistency test for seq_dataset

a

sklearn/utils/tests/test_seq_dataset.py

new if statement

add doc

sklearn/utils/seq_dataset.pyx.tp

minor changes

minor changes

typo fix

check numeric accuracy only up 5th decimal

Address oliver's request for changing test name

add test for make_dataset and rename a variable in test_seq_dataset
    @NelleV
    Imbert Arthur authored and NelleV committed Jul 8, 2018
    Copy the full SHA
    9463e21 View commit details
    Browse the repository at this point in the history

  3. FIX tests

    @NelleV
    NelleV committed Jul 8, 2018
    Copy the full SHA
    c1b795b View commit details
    Browse the repository at this point in the history

  4. TST more numerically stable test_sgd.test_tol_parameter

    @ogrisel @NelleV
    ogrisel authored and NelleV committed Jul 8, 2018
    Copy the full SHA
    8a46660 View commit details
    Browse the repository at this point in the history

  5. Added benchmarks to compare SAGA 32b and 64b

    @NelleV
    NelleV committed Jul 8, 2018
    Copy the full SHA
    9168b8f View commit details
    Browse the repository at this point in the history

  6. Fixing gael's comments

    @NelleV
    NelleV committed Jul 8, 2018
    Copy the full SHA
    8d89662 View commit details
    Browse the repository at this point in the history

  7. fix

    @NelleV
    NelleV committed Jul 8, 2018
    Copy the full SHA
    21c3f98 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. Merge remote-tracking branch 'origin/master' into NelleV-henley_is_87… 

    …69_minus_merged
    @glemaitre
    glemaitre committed Jul 17, 2018
    Copy the full SHA
    2534661 View commit details
    Browse the repository at this point in the history

  2. solve some issues

    @glemaitre
    glemaitre committed Jul 17, 2018
    Copy the full SHA
    b10e2d7 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into NelleV-henley_is_87… 

    …69_minus_merged
    @glemaitre
    glemaitre committed Jul 17, 2018
    Copy the full SHA
    3af8134 View commit details
    Browse the repository at this point in the history

  4. PEP8

    @glemaitre
    glemaitre committed Jul 17, 2018
    Copy the full SHA
    30f2080 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Address lesteve comments

    @glemaitre
    glemaitre committed Jul 19, 2018
    Copy the full SHA
    7babe3e View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Merge branch 'master' into henley_is_8769_minus_merged

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    8690bd6 View commit details
    Browse the repository at this point in the history

  2. fix merging

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    7864555 View commit details
    Browse the repository at this point in the history

  3. avoid using assert_equal

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    b83873c View commit details
    Browse the repository at this point in the history

  4. use all_close

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    7248300 View commit details
    Browse the repository at this point in the history

  5. use explicit ArrayDataset64 and CSRDataset64

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    53fc38e View commit details
    Browse the repository at this point in the history

  6. fix: remove unused import

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    5eb99b8 View commit details
    Browse the repository at this point in the history

  7. Use parametrized to cover ArrayDaset-CSRDataset-32-64 matrix

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    191da7a View commit details
    Browse the repository at this point in the history

  8. for consistency use 32 first then 64 + add 64 suffix to variables

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    a6e9309 View commit details
    Browse the repository at this point in the history

  9. it would be cool if this worked !!!

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    0d06913 View commit details
    Browse the repository at this point in the history

  10. more verbose version

    @massich
    massich committed Feb 25, 2019
    Copy the full SHA
    635d301 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. revert SGD changes as much as possible.

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    380bc10 View commit details
    Browse the repository at this point in the history

  2. Add solvers back to bench_saga

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    273651f View commit details
    Browse the repository at this point in the history

  3. make 64 explicit in the naming

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    edc56c1 View commit details
    Browse the repository at this point in the history

  4. remove checking native python type + add comparison between 32 64

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    c17000f View commit details
    Browse the repository at this point in the history

  5. Add whatsnew with everyone with commits

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    e5a034d View commit details
    Browse the repository at this point in the history

  6. simplify a bit the testing

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    567e640 View commit details
    Browse the repository at this point in the history

  7. simplify the parametrize

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    0574e90 View commit details
    Browse the repository at this point in the history

  8. update whatsnew

    @massich
    massich committed Feb 26, 2019
    Copy the full SHA
    6bae447 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. fix pep8

    @massich
    massich committed Feb 27, 2019
    Copy the full SHA
    959cd8c View commit details
    Browse the repository at this point in the history