-
-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] Fix warning in doc #13353
[MRG+1] Fix warning in doc #13353
Conversation
Changing this to MRG: we can merge this, and you start a new one to continue. |
Thank you. +1 for merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -176,6 +176,8 @@ program. | |||
- 2015 - `Raghav RV <https://github.com/raghavrv>`_, Wei Xue | |||
- 2016 - `Nelson Liu <http://nelsonliu.me>`_, `YenChen Lin <https://yclin.me/>`_ | |||
|
|||
.. _Vlad Niculae: https://vene.ro/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why sphinx does not find the identical ref in doc/whats_new/_contributors.rst
?
It feels a bit weird like that. I would rather make sphinx find the ref, or write directly:
`Vlad Niculae <https://vene.ro/>`_
Merging |
* DOC Fix warning in about.rst * DOC Fix warning in datasets/index.rst * DOC Remove backtick causing warning
This reverts commit 2fe1a4f.
This reverts commit 2fe1a4f.
* DOC Fix warning in about.rst * DOC Fix warning in datasets/index.rst * DOC Remove backtick causing warning
This PR intends to fix multiple warnings when building the doc.
I think this is linked to #11533