Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix warning in doc #13353

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

marineLM
Copy link
Contributor

@marineLM marineLM commented Mar 1, 2019

This PR intends to fix multiple warnings when building the doc.
I think this is linked to #11533

@GaelVaroquaux GaelVaroquaux added this to To do in Sprint Paris 2019 via automation Mar 1, 2019
@GaelVaroquaux GaelVaroquaux changed the title [WIP] Fix warning in doc [MRG] Fix warning in doc Mar 1, 2019
@GaelVaroquaux
Copy link
Member

Changing this to MRG: we can merge this, and you start a new one to continue.

@GaelVaroquaux GaelVaroquaux changed the title [MRG] Fix warning in doc [MRG+1] Fix warning in doc Mar 1, 2019
@GaelVaroquaux
Copy link
Member

Thank you. +1 for merge!

@GaelVaroquaux GaelVaroquaux moved this from To do to Needs review in Sprint Paris 2019 Mar 1, 2019
Copy link
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -176,6 +176,8 @@ program.
- 2015 - `Raghav RV <https://github.com/raghavrv>`_, Wei Xue
- 2016 - `Nelson Liu <http://nelsonliu.me>`_, `YenChen Lin <https://yclin.me/>`_

.. _Vlad Niculae: https://vene.ro/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why sphinx does not find the identical ref in doc/whats_new/_contributors.rst ?
It feels a bit weird like that. I would rather make sphinx find the ref, or write directly:

`Vlad Niculae <https://vene.ro/>`_

@GaelVaroquaux
Copy link
Member

Merging

@GaelVaroquaux GaelVaroquaux merged commit 703991f into scikit-learn:master Mar 2, 2019
Sprint Paris 2019 automation moved this from Needs review to Done Mar 2, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
* DOC Fix warning in about.rst

* DOC Fix warning in datasets/index.rst

* DOC Remove backtick causing warning
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
* DOC Fix warning in about.rst

* DOC Fix warning in datasets/index.rst

* DOC Remove backtick causing warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants