[MRG] Fix empty clusters not correctly relocated #13486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Mar 22, 2019
| @@ -922,3 +923,15 @@ def test_iter_attribute(): | |||
| estimator = KMeans(algorithm="elkan", max_iter=1) | |||
| estimator.fit(np.random.rand(10, 10)) | |||
| assert estimator.n_iter_ == 1 | |||
|
|
|||
|
|
|||
| def test_k_means_empty_cluster_relocated(): | |||
jeremiedbb
force-pushed
the
fix-kmeans-relocate-empty-clusters
branch
from
f031479
to
cca9378
Compare
|
@NicolasHug I think this PR can be merged |
NicolasHug
reviewed
Apr 12, 2019
doc/whats_new/v0.21.rst
Outdated
| @@ -88,7 +88,11 @@ Support for Python 3.4 and below has been officially dropped. | |||
| - |API| The ``n_components_`` attribute in :class:`cluster.AgglomerativeClustering` | |||
| and :class:`cluster.FeatureAgglomeration` has been renamed to | |||
| ``n_connected_components_``. | |||
|
|
|||
There was a problem hiding this comment.
seems like there's a newline at the wrong place
There was a problem hiding this comment.
yep, merged master too quickly...
|
Thanks @jeremiedbb ! |
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…weight(scikit-learn#13486)" This reverts commit 79f12c4.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…weight(scikit-learn#13486)" This reverts commit 79f12c4.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sample weights in KMeans, empty clusters are not correctly relocated.
basically what was done is
the added test fails on master