[MRG+1] Convert y in GradientBoosting to float64 instead of float32 #13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
changed the title
jnothman
approved these changes
Mar 27, 2019
| @@ -1432,7 +1432,7 @@ def fit(self, X, y, sample_weight=None, monitor=None): | |||
| self._clear_state() | |||
|
|
|||
| # Check input | |||
| X, y = check_X_y(X, y, accept_sparse=['csr', 'csc', 'coo'], dtype=DTYPE) | |||
| X = check_array(X, accept_sparse=['csr', 'csc', 'coo'], dtype=DTYPE) | |||
There was a problem hiding this comment.
It's worth commenting why check_X_y is not used.
adrinjalali
changed the title
thomasjpfan
approved these changes
Mar 28, 2019
| @@ -44,7 +44,7 @@ | |||
| from time import time | |||
| from ..model_selection import train_test_split | |||
| from ..tree.tree import DecisionTreeRegressor | |||
| from ..tree._tree import DTYPE | |||
| from ..tree._tree import DTYPE, DOUBLE | |||
There was a problem hiding this comment.
It is interesting how this is our naming convention for the dtypes of X and y. In the future we may consider X_DTYPE and Y_DTYPE.
There was a problem hiding this comment.
Yeah I know. You're the second +1 here now @thomasjpfan, wanna push the green button? ;)
|
Ta @adrinjalali |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…32 (scikit-learn#13524)" This reverts commit 2502111.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…32 (scikit-learn#13524)" This reverts commit 2502111.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9098
If not float64, the decision trees would each convert it to a double.