New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+2] FIX DummyEstimator and a single output 2d input list/array #13545
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8b84ff1
Add column_or_1d to account for dataframe y
nsorros c0b8b4a
Add test
nsorros b70f960
make the diff cleaner
nsorros 9dc5ad6
switched pandas import for 2d array
nsorros ca2bd64
change test to a simple comparison between 1d and 2d y
nsorros 6be4924
flake8 errors in tests
nsorros 7c4db74
Add warning to acieve consistent behaviour as in other classifiers
nsorros aa8cc9f
Update whats new file
nsorros 74c4d99
merge upstream/master
adrinjalali 03abdc9
remove redundant code, fix regression
adrinjalali 3494053
remove unnecessary import
adrinjalali abce3f3
add comment on test
adrinjalali 67abc56
address comments
adrinjalali 6433ba4
fix what's new entry
adrinjalali fee0380
Update doc/whats_new/v0.21.rst
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"1d dimensional y with ndim=2" makes no sense to me. Do you mean "column vector"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it was a copy paste from the old issue, sorry. Fixed.