Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] DOC Fix missing space after backquotes #13551

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

Framartin
Copy link
Contributor

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

One missing space after the double backquotes makes the inline markup for code samples to expend to the next one. Then, the sentence is incorrectly formatted as:
before

Instead of:
after

@Framartin
Copy link
Contributor Author

Framartin commented Mar 31, 2019

There is only one other similar mistake in doc/whats_new/v0.17.rst (see here):

grep -rI --include='*.html' '`\`\`' doc/_build/html/stable/

returns:

doc/_build/html/stable/whats_new/v0.17.html:<code class="docutils literal notranslate"><span class="pre">class_weight='balanced'```or</span> <span class="pre">``class_weight='auto'</span></code>.

Should I fix it too?

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should I fix it too?

Sure, thanks!

@Framartin
Copy link
Contributor Author

Thanks @NicolasHug! Fixed in 444a928

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Framartin

@qinhanmin2014 qinhanmin2014 merged commit 26f6909 into scikit-learn:master Apr 1, 2019
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Apr 25, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants