-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] DOC Fix missing space after backquotes #13551
Conversation
There is only one other similar mistake in grep -rI --include='*.html' '`\`\`' doc/_build/html/stable/ returns: doc/_build/html/stable/whats_new/v0.17.html:<code class="docutils literal notranslate"><span class="pre">class_weight='balanced'```or</span> <span class="pre">``class_weight='auto'</span></code>. Should I fix it too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should I fix it too?
Sure, thanks!
Thanks @NicolasHug! Fixed in 444a928 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Framartin
This reverts commit a267f3e.
This reverts commit a267f3e.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
One missing space after the double backquotes makes the inline markup for code samples to expend to the next one. Then, the sentence is incorrectly formatted as:
![before](https://user-images.githubusercontent.com/1850174/55292390-afd04900-53c0-11e9-9d13-87f92f579cd5.png)
Instead of:
![after](https://user-images.githubusercontent.com/1850174/55292392-b363d000-53c0-11e9-96ca-7699743b92ba.png)