Parameter for stacking missing indicator into iterative imputer #13601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dicator transform into it
|
@jnothman @jeremiedbb does it make sense? |
jnothman
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
Yes, it makes sense :)
One point of difference between simple and iterative however is that there might be sense in including the missing indicators in each iteration of training. But that involves more thinking and I don't think we need to solve it for this to be valuable.
thomasjpfan
reviewed
Apr 13, 2019
Co-Authored-By: DanilBaibak <danil.baibak@gmail.com>
…mputer' of github.com:DanilBaibak/scikit-learn into Parameter-For-Stacking-MissingIndicator-Into-IterativeImputer
jnothman
approved these changes
Apr 15, 2019
jnothman
reviewed
Apr 15, 2019
|
Glad to help 😊 |
NicolasHug
reviewed
Apr 15, 2019
Co-Authored-By: DanilBaibak <danil.baibak@gmail.com>
|
Thanks @DanilBaibak ! |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…mputer (scikit-learn#13601)" This reverts commit e501fb4.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…mputer (scikit-learn#13601)" This reverts commit e501fb4.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Continue of the #12583.
What does this implement/fix? Explain your changes.
As was mentioned in #12583, we would be good to add option to stack MissingIndicator transform into the output of the IterativeImputer's transform.