2D sample weight for MultiOutputEstimator #13714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like I should add some tests for 2D sample weights. |
|
yes, there should be tests, and possibly an example? I'm not sure we want to support this because it adds quite a bit of complexity. |
|
why would we add this here and not in the other estimators supporting multi-output? |
|
closing with lack of response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #10912.
What does this implement/fix? Explain your changes.
The original issue #10912 is about 2D sample weight for MultiOutputRegressor.
I made modifications in MultiOutputEstimator, so that this feature is available for not only MultiOutputRegressor but also MultiOutputClassifier.
Any other comments?
2D sample weight is useful in my use case, because different outputs have different numerical ranges.