[MRG] MAINT Fixes apt by removing the ubuntu-toolchain-r/test repo #13934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is weird how one of the packages just disappeared from http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu/pool/main/g/gcc-8/ |
Merged
|
This appears successful! Nice work. How did you discover this solution? |
|
Started a ubuntu 16.04 docker container (which does not include the launchpad.net repo), confirmed that the apt dependencies can be installed and build scikit-learn with it. |
jnothman
approved these changes
May 23, 2019
|
Merging. Thanks @thomasjpfan ! |
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13928
What does this implement/fix? Explain your changes.
This PR removes the
ubuntu-toolchain-r/testfrom the apt repository. This PPA is not added by default on ubuntu 16.04 LTS. With this PR everything will be pulled from thehttp://archive.ubuntu.com/ubunturepo.