Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Add warm_start parameter to HistGradientBoosting #14012

Merged
merged 27 commits into from Jun 21, 2019
Merged

[MRG] Add warm_start parameter to HistGradientBoosting #14012

merged 27 commits into from Jun 21, 2019

Commits on Jun 3, 2019

  1. Add warm_start parameter to HistGradientBoosting

    johann.faouzi committed Jun 3, 2019
    Copy the full SHA
    4da6e96 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Add more code for warm start in HistGBM.

    johann.faouzi committed Jun 4, 2019
    Copy the full SHA
    10bcaa9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Fix train_score_ and validation_score_ shapes in docstrings.

    johann.faouzi committed Jun 5, 2019
    Copy the full SHA
    ad40048 View commit details
    Browse the repository at this point in the history

  2. Add tests for warm_start in HistGBM.

    johann.faouzi committed Jun 5, 2019
    Copy the full SHA
    0ed1535 View commit details
    Browse the repository at this point in the history

  3. Improvements after first review of adding warm_start to HistGBM.

    johann.faouzi committed Jun 5, 2019
    Copy the full SHA
    b246621 View commit details
    Browse the repository at this point in the history

  4. Use an int for rng in test_warm_start_yields_identical_results.

    johann.faouzi committed Jun 5, 2019
    Copy the full SHA
    0dc6247 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. Remove unnecessary private attributes in BaseHistGradientBoosting.

    johann.faouzi committed Jun 6, 2019
    Copy the full SHA
    4bcb9c4 View commit details
    Browse the repository at this point in the history

  2. Remove _last_gradients and _last_hessians from BaseHistGradientBoosting.

    johann.faouzi committed Jun 6, 2019
    Copy the full SHA
    94856d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Update code after the second review.

    johann.faouzi committed Jun 7, 2019
    Copy the full SHA
    62c9ce1 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Add warm starting in HistGBM in whats_new

    johann.faouzi committed Jun 11, 2019
    Copy the full SHA
    e5806de View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary clearing state.

    johann.faouzi committed Jun 11, 2019
    Copy the full SHA
    4bb1c05 View commit details
    Browse the repository at this point in the history

  3. Add more tests for warm starting.

    johann.faouzi committed Jun 11, 2019
    Copy the full SHA
    b0de8c4 View commit details
    Browse the repository at this point in the history

  4. Reevert whitespace removing.

    johann.faouzi committed Jun 11, 2019
    Copy the full SHA
    e9d4011 View commit details
    Browse the repository at this point in the history

  5. Revert whitespace removing.

    johann.faouzi committed Jun 11, 2019
    Copy the full SHA
    350a5c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Improve code after review and add seeds for consistent RNG.

    johann.faouzi committed Jun 12, 2019
    Copy the full SHA
    bb35e38 View commit details
    Browse the repository at this point in the history

  2. Revert trailing whitespaces.

    johann.faouzi committed Jun 12, 2019
    Copy the full SHA
    1f4c6b7 View commit details
    Browse the repository at this point in the history

  3. Update code after review

    johann.faouzi committed Jun 12, 2019
    Copy the full SHA
    99514fb View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Add minor corrections to code and docstring.

    johann.faouzi committed Jun 13, 2019
    Copy the full SHA
    d0e307c View commit details
    Browse the repository at this point in the history

  2. Move warm starting tests in separate file.

    johann.faouzi committed Jun 13, 2019
    Copy the full SHA
    c81fc8d View commit details
    Browse the repository at this point in the history

  3. Revert changes made to _assert_predictor_equal

    johann.faouzi committed Jun 13, 2019
    Copy the full SHA
    2636cf0 View commit details
    Browse the repository at this point in the history

  4. Change checks in test_warm_start_clear

    johann.faouzi committed Jun 13, 2019
    Copy the full SHA
    10f0298 View commit details
    Browse the repository at this point in the history

  5. Re-add _assert_predictor_equal in test_warm_start_clear

    johann.faouzi committed Jun 13, 2019
    Copy the full SHA
    f59ff5a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Add _assert_predictor_equal in test_warm_start_clear

    johann.faouzi committed Jun 14, 2019
    Copy the full SHA
    7597c61 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add_warm_start_to_hist_gradient_boost' of https://githu… 

    …b.com/johannfaouzi/scikit-learn into add_warm_start_to_hist_gradient_boost
    johann.faouzi committed Jun 14, 2019
    Copy the full SHA
    4438ae2 View commit details
    Browse the repository at this point in the history

  3. Change parameter order

    johann.faouzi committed Jun 14, 2019
    Copy the full SHA
    3cd0cef View commit details
    Browse the repository at this point in the history

  4. Update code after second review

    johann.faouzi committed Jun 14, 2019
    Copy the full SHA
    eedee53 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. import explicitely numpy test functions

    @glemaitre
    glemaitre committed Jun 21, 2019
    Copy the full SHA
    5fc2880 View commit details
    Browse the repository at this point in the history