[MRG] Release 0.20.4 #14443

jnothman · 2019-07-23T03:16:49Z

Not to be squashed.

This takes the PRs from https://github.com/scikit-learn/scikit-learn/milestone/30?closed=1, constructs a change log for them, upgrades vendored Joblib from 0.13.0 to 0.13.2, proposes a release date of 29 July (the coming Monday) and bumps the version.

I would aim to synchronise release with 0.21.3 (#14188), but this one is good to go (pending CI and review) as far as I'm concerned.

TODO after approval:

…ifiedKFold (scikit-learn#13124) * Enable StratifiedKFold to produce different splits * what's new * redundant statement * update what's new * redundant comment * add a test * move what's new entry * review comment * review comment

…#13539)

scikit-learn#13772)

…#14235)

scikit-learn#14237) * FIX Raise error on reordered columns in ColumnTransformer with remainder * FIX Check for different length of X.columns to avoid exception * FIX linter, line too long * FIX import _check_key_type from its new location utils * ENH Adjust doc, allow added columns * Fix comment typo as suggested, remove non-essential exposition in doc * Add PR 14237 to what's new * Avoid AttributeError in favor of ValueError "column names only for DF" * ENH Add check for n_features_ for array-likes and DataFrames * Rename self.n_features to self._n_features * Replaced backslash line continuation with parenthesis * Style changes

jnothman · 2019-07-23T03:33:40Z

AppVeyor does not appear to be running. Have we disabled it?

jnothman · 2019-07-23T03:36:07Z

Conda is throwing PackageNotFoundErrors that I'm not sure how to resolve.

jnothman · 2019-07-23T04:03:59Z

The last commit has strangely not appeared here.

* [scipy-dev] manually scramble the indices * [scipy-dev] review comment

codecov · 2019-07-23T06:18:24Z

Codecov Report

Merging #14443 into 0.20.X will decrease coverage by 1.54%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           0.20.X   #14443      +/-   ##
==========================================
- Coverage   93.13%   91.59%   -1.55%     
==========================================
  Files         433      423      -10     
  Lines       75144    73552    -1592     
==========================================
- Hits        69987    67367    -2620     
- Misses       5157     6185    +1028

Impacted Files	Coverage Δ
sklearn/feature_selection/rfe.py	`97.67% <ø> (ø)`	⬆️
...ternals/joblib/externals/loky/backend/reduction.py	`71.31% <ø> (-5.74%)`	⬇️
sklearn/model_selection/_search.py	`98.96% <ø> (-0.35%)`	⬇️
sklearn/model_selection/_validation.py	`97.35% <ø> (ø)`	⬆️
sklearn/model_selection/_split.py	`99.17% <100%> (ø)`	⬆️
sklearn/cluster/dbscan_.py	`100% <100%> (ø)`	⬆️
sklearn/cluster/k_means_.py	`95.96% <100%> (-1.79%)`	⬇️
sklearn/neighbors/tests/test_kde.py	`99.28% <100%> (ø)`	⬆️
sklearn/model_selection/tests/test_split.py	`92.5% <100%> (+0.06%)`	⬆️
sklearn/externals/joblib/__init__.py	`100% <100%> (ø)`	⬆️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b136e9...c4d6722. Read the comment docs.

jnothman · 2019-07-23T11:52:29Z

Finally it's green!

amueller · 2019-07-23T16:30:32Z

Should this be included? #13995, #14114?
Don't have a strong opinion though.

jnothman · 2019-07-23T21:59:09Z

Neither has until now been proposed for a patch release as far as I know, not for 0.20 nor for 0.21

jnothman · 2019-07-27T09:06:53Z

Could core devs please review and approve release? Thanks

adrinjalali · 2019-07-28T13:52:02Z

Should we fix, or open an issue for some the commits you have here, like 7b0b97b (sorry if that's done and I've missed them)?

jnothman · 2019-07-28T21:32:32Z

I am pretty sure they are covered elsewhere. Some things like warnings in tests have quick fixes in the patch branch because their fix in master was more substantial or depended on other changes.

jnothman · 2019-07-28T22:56:15Z

@adrinjalali, for that specific issue see #14125

jnothman · 2019-07-29T02:54:03Z

Are you fine with this one too, @qinhanmin2014?

qinhanmin2014

CIs are green and the diff seems reasonable, so LGTM and thanks for making this happen.
Though personally I'm not a big fan of 0.20.X, backporting is time-consuming and I guess it's impossible to backport all the bug fixes (only backporting selected bug fixes seems strange). If users want to avoid bugs, they should turn to python3.X.

qinhanmin2014 · 2019-07-29T04:04:25Z

doc/whats_new/v0.20.rst

+..............................
+
+- |Fix| Fixed a bug in :class:`cluster.KMeans` where KMeans++ initialisation
+  could rarely result in an IndexError. :issue:`11756` by `Joel Nothman`_.


this entry is not included in master (and 0.21.3)?

Ahh, true. It's now included in the 0.20.4 section in master at least...

Sorry for missing it.

adrinjalali

Also, would be happy to give a hand on the task list you have on each release.

jnothman · 2019-07-29T08:44:03Z

The task list is not a great effort... I have been wondering though about whether we can put it all into an Azure deployment Pipeline (cf. #13949). It would help by only actually doing the tagging if the wheels (and ideally conda-forge) are successfully built, and it would avoid running back and forth between here and macpython.

rth

Thanks for doing the release work @jnothman ! The list of commits and the release notes LGTM.

jnothman · 2019-07-29T13:31:17Z

Building wheels at https://travis-ci.org/MacPython/scikit-learn-wheels/builds/564977472

qinhanmin2014 · 2019-07-29T13:36:21Z

Thanks. In case you missed some emails, my review is silently ignored (#14443 (comment)), but that's trivial.

qinhanmin2014 and others added 11 commits July 23, 2019 13:03

FIX Explicitly ignore SparseEfficiencyWarning in DBSCAN (scikit-learn…

319f27a

…#13539)

[MRG] Save sample_weight_arr instead of sample_weight in KernelDensity (

936a9fa

scikit-learn#13772)

DOC Make explicit that groups required *Group* splitter (scikit-learn…

3e14f61

…#14235)

FIX IndexError due to imprecision in KMeans++ (scikit-learn#11756)

4f9e557

What's new for scikit-learn#11756

e423647

MNT Set release version to 0.20.4

a2d1b07

Upgrade joblib to version 0.13.2

1569889

DOC what's new for joblib upgrade

ac2efa2

Require sphinx 1.6.* rather than 1.6.2

92af13d

jnothman added 2 commits July 23, 2019 13:41

Upgrade doc build requirements since packages are gone from conda

6dd45f0

Use arbitrary versions in Python 2 Circle

21d3033

jnothman closed this Jul 23, 2019

jnothman reopened this Jul 23, 2019

jnothman and others added 3 commits July 23, 2019 15:13

remove matplotlib version req

9498fa6

TST Manually scramble the indices in svm tests (scikit-learn#12890)

f9687ca

* [scipy-dev] manually scramble the indices * [scipy-dev] review comment

Fixes for travis on latest deps

c4d6722

jnothman and others added 8 commits July 23, 2019 16:19

Add conda-forge to test old deps no longer on main channels

686cde8

Docstring indent

92a6ef0

TST Sets decimal

09b3b52

Debug conda install

22ca031

Add tol to silence warning

4b143a4

Not getting anywhere with scipy 0.16. Try 0.17.

87f67ca

Fix up use of ignore_warnings

824f7aa

Scipy.sparse may only accept arrays, not lists

34ec4ea

jnothman added 4 commits July 23, 2019 18:18

ignore SparseSeries warning

7b0b97b

Disable coverage in py3.4 due to deps

6df9737

Avoid installing pytest-cov if no COVERAGE

2dc1aff

Make sure coverage is there even if conda removes it

bfaefaf

qinhanmin2014 approved these changes Jul 29, 2019

View reviewed changes

adrinjalali approved these changes Jul 29, 2019

View reviewed changes

rth approved these changes Jul 29, 2019

View reviewed changes

jnothman added 3 commits July 29, 2019 22:47

DOC update release date

201ef7a

DOC update news from 0.20 perspective

989fbf4

DOC fix typo in what's new version numbers

91bd0fe

jnothman force-pushed the for0.20.4 branch from 01c7d07 to 91bd0fe Compare July 29, 2019 12:55

DOC update news

c0bd85f

jnothman merged commit c0bd85f into scikit-learn:0.20.X Jul 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] Release 0.20.4 #14443

[MRG] Release 0.20.4 #14443

jnothman commented Jul 23, 2019 •

edited

jnothman commented Jul 23, 2019

jnothman commented Jul 23, 2019

jnothman commented Jul 23, 2019

codecov bot commented Jul 23, 2019

jnothman commented Jul 23, 2019

amueller commented Jul 23, 2019 •

edited

jnothman commented Jul 23, 2019

jnothman commented Jul 27, 2019

adrinjalali commented Jul 28, 2019

jnothman commented Jul 28, 2019

jnothman commented Jul 28, 2019

jnothman commented Jul 29, 2019

qinhanmin2014 left a comment

qinhanmin2014 Jul 29, 2019

jnothman Jul 29, 2019

jnothman Jul 29, 2019

adrinjalali left a comment

jnothman commented Jul 29, 2019 via email

rth left a comment

jnothman commented Jul 29, 2019

qinhanmin2014 commented Jul 29, 2019

[MRG] Release 0.20.4 #14443

[MRG] Release 0.20.4 #14443

Conversation

jnothman commented Jul 23, 2019 • edited

jnothman commented Jul 23, 2019

jnothman commented Jul 23, 2019

jnothman commented Jul 23, 2019

codecov bot commented Jul 23, 2019

Codecov Report

jnothman commented Jul 23, 2019

amueller commented Jul 23, 2019 • edited

jnothman commented Jul 23, 2019

jnothman commented Jul 27, 2019

adrinjalali commented Jul 28, 2019

jnothman commented Jul 28, 2019

jnothman commented Jul 28, 2019

jnothman commented Jul 29, 2019

qinhanmin2014 left a comment

Choose a reason for hiding this comment

qinhanmin2014 Jul 29, 2019

Choose a reason for hiding this comment

jnothman Jul 29, 2019

Choose a reason for hiding this comment

jnothman Jul 29, 2019

Choose a reason for hiding this comment

adrinjalali left a comment

Choose a reason for hiding this comment

jnothman commented Jul 29, 2019 via email

rth left a comment

Choose a reason for hiding this comment

jnothman commented Jul 29, 2019

qinhanmin2014 commented Jul 29, 2019

jnothman commented Jul 23, 2019 •

edited

amueller commented Jul 23, 2019 •

edited