[MRG] BLD Do not get version from circle #14462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Apparently this is not the right fix. list_versions is now resulting in an
HTTP 404.
|
|
What I had in this PR was incorrect. The issue comes from dev's documentation.html does not have a "VERSION:" to pass the regex. |
|
I wonder if something with sphinx 2.1 is doing something weird here. |
|
It was sphinx 1.7 that changes this: https://github.com/sphinx-doc/sphinx/blob/a498960de9039b0d0c8d24f75f32fa4acd5b75e1/CHANGES#L1317 The documentation options are moved to a separate file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix https://circleci.com/gh/scikit-learn/scikit-learn/66274
The https://api.github.com/repos/scikit-learn/scikit-learn.github.io/contents/ json seems to have a
name=circlewithtype=dir. This will try to downloaddocumentation.htmlthat does not exists.