Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] text vectorizers should raise warnings when user params will be unused #14602

Merged
merged 42 commits into from Sep 6, 2019
Merged

[MRG] text vectorizers should raise warnings when user params will be unused #14602

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
2662657
Adding link to User guide for make_column_transformer
Jul 4, 2019
a57f617
Describe the arguments for *transformers.
Jul 5, 2019
799408d
Merge remote-tracking branch 'upstream/master'
Aug 8, 2019
7262214
#14580 - Add first warning for CountVectorizer for stop_words and ana…
Aug 8, 2019
958ccaa
removing spaces
Aug 8, 2019
e91c0df
changing message
Aug 8, 2019
1251dca
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn
Aug 8, 2019
439e59c
#14580 - Add Warning for analyzer and stop word pair
Aug 8, 2019
15a58d2
modifying warning text
Aug 8, 2019
5ddb9da
moving the code logic to fit
Aug 8, 2019
5491fde
bracket
Aug 8, 2019
dc61048
flake8 changes
Aug 8, 2019
0ef396c
Adding Unit test case for Stop Word and analyzer != 'word
Aug 8, 2019
67168ea
flake8 changes
Aug 8, 2019
0c6f5cd
more flake8
Aug 8, 2019
5cc792b
Update sklearn/feature_extraction/tests/test_text.py
getgaurav2 Aug 8, 2019
2f0f572
incorporating suggestions from @rth
Aug 8, 2019
0131118
flake 8 suggestions
Aug 8, 2019
1321a32
Using pytest.warns and parameterizing the test case .
Aug 8, 2019
e8a338c
Adding minor changes to trigger another build since a few test cases …
Aug 9, 2019
28ac365
Adding Warning and Unit test for analyzer and tokenizer pair
Aug 10, 2019
b0e1431
Adding warning and unit test for tokenizer and token-pattern pair
Aug 10, 2019
112eec0
creating new instance of Vectorizer() for each test and reusing msg v…
Aug 10, 2019
383c249
Adding Warning and Unit test for callable(analyzer) and preprocessor …
Aug 10, 2019
63243a5
Modifying the documentation
Aug 10, 2019
71496d1
Adding warning in the fit methods for HashingVectorizer and TfidfVect…
Aug 10, 2019
d0d1930
change documentation for CountVectorizer , HashingVectorizer for p…
Aug 10, 2019
d1c2574
Adding warning and unit test for token_pattern and analyzer != 'word'
Aug 12, 2019
6144ec7
Adding _missing_param_warning(self)
Aug 15, 2019
1bbe85c
Adding analyzer!=word warnings inside the build_analyzer function
Aug 15, 2019
7564966
calling build_analyzer inside fit() method for Hashing vectorizer
Aug 16, 2019
872be9f
1. Further parameterizing the unit test function
Aug 17, 2019
002b1b3
Merge branch 'master' of https://github.com/getgaurav2/scikit-learn i…
Aug 18, 2019
4da39b3
flake8 changes
Aug 18, 2019
93e4e6f
resolving merge conflicts
Aug 18, 2019
7e8219e
removing an extra warning added by mistake.
Aug 24, 2019
26d8ae0
commenting assert len(records) == 1 for the time
Aug 24, 2019
4c1e87c
Taking the analyzer!= word validations outside of build_analyzer
Sep 4, 2019
42fba5e
Rename the warning function from _missing_param_warning to _warn_for_…
Sep 4, 2019
0268483
Adding enhancement section for this pull request
Sep 5, 2019
6897fdf
minor fixes
Sep 5, 2019
706405a
modifying language
Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion sklearn/feature_extraction/text.py
View file
Open in desktop
Expand Up @@ -714,7 +714,7 @@ def fit(self, X, y=None):
"string object received.")

self._validate_params()

self.build_analyzer()
getgaurav2 marked this conversation as resolved.
Show resolved Hide resolved
self._missing_param_warning()

self._get_hasher().fit(X, y=y)
Expand Down