DOC Reorganize plot_nca_illustration example into subsections #14795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Aug 26, 2019
| plt.show() | ||
|
|
||
| ############################################################################## | ||
| # We use :class:`~sklearn.neighbors.NeighborhoodComponentsAnalysis` to learn an |
There was a problem hiding this comment.
Add a title e.g. "learning the embedding"?
|
Can you please address the comments @m-clare ? |
NicolasHug
approved these changes
Sep 9, 2019
|
@kellycarmody, |
|
@reshamas just FYI, I made sure all PRs were reviewed by Monday after the sprint (2 weeks ago.) I pinged the authors on Monday last week, and this morning I addressed the comments myself when the authors didn't answer. |
|
@NicolasHug |
|
Quick look @thomasjpfan ? This is from the sprint |
thomasjpfan
approved these changes
Sep 18, 2019
thomasjpfan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partial fixes #14703
What does this implement/fix? Explain your changes.
Reorganize examples/neighbors/plot_nca_illustration.py example into subsections
Any other comments?
Working with @olgadk7 at WiMLDS sprint