[MRG] added validation for sample weight in DummyRegressor #15505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
[MRG] fixing test_common.py issue caused by prior commit with check_consistent_length(X, y, sample_weight) check validation fo X y |
add check_consistent_length(X, y, sample_weight) to check for X y input
amueller
reviewed
Nov 2, 2019
amueller
reviewed
Nov 2, 2019
amueller
approved these changes
Nov 2, 2019
|
You can add @MDouriez using this https://help.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors Looks good to me otherwise |
theoptips
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15358 DummyRegressor
What does this implement/fix? Explain your changes.
Use utils.validation._check_sample_weight
to replace check_consistent_length(X, y, sample_weight)
Ran pytest
test_dummy.py passed all tests
Collaborator:
Work with @MDouriez continued