DOC add versionadded to OneHotEcoder, LabelEncoder #15506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otEcoder, LabelEncode, OrdinalEncoder
|
Looks good to me format-wise. |
amueller
reviewed
Nov 2, 2019
amueller
reviewed
Nov 2, 2019
|
@eickenberg essentially I searched |
… per AMueller suggestion, rebuilt doc
rth
approved these changes
Nov 15, 2019
rth
changed the title
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 18, 2019
and OrdinalEncoder
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Nov 18, 2019
and OrdinalEncoder
jnothman
reviewed
Feb 27, 2020
| @@ -171,6 +171,8 @@ class OneHotEncoder(_BaseEncoder): | |||
|
|
|||
| Read more in the :ref:`User Guide <preprocessing_categorical_features>`. | |||
|
|
|||
| .. versionchanged:: 0.20 | |||
There was a problem hiding this comment.
I don't think we should have versionchanged without specifying what's changed. @rth, is this a convention we have adopted?
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
and OrdinalEncoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add versionadded in doctrings for OneHotEcoder, LabelEncode, OrdinalEncoder
Reference Issues/PRs
#15426
What does this implement/fix? Explain your changes.
Any other comments?