Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] DOC Remove inconsistency in early stopping doc for GBDT #15623

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

NicolasHug
Copy link
Member

We don't early-stop by default since #14516 isn't merged yet

quick review for @adrinjalali @rth @glemaitre ?

@NicolasHug NicolasHug added this to the 0.22 milestone Nov 13, 2019
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM.

Remove lie in early stopping doc for GBDT

Maybe "inconsistency" ))

@NicolasHug NicolasHug changed the title [MRG] DOC Remove lie in early stopping doc for GBDT [MRG] DOC Remove inconsistency in early stopping doc for GBDT Nov 13, 2019
@adrinjalali adrinjalali merged commit 25e72d3 into scikit-learn:master Nov 14, 2019
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Nov 18, 2019
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Nov 18, 2019
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants