Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Further 0.22 whats_new cleanup #15675

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

adrinjalali
Copy link
Member

This PR mostly sorts the entries in categories.

@adrinjalali adrinjalali added this to the 0.22 milestone Nov 20, 2019
- |Fix| Fixed a bug in :func:`datasets.fetch_openml`, which failed to load
an OpenML dataset that contains an ignored feature.
:pr:`14623` by :user:`Sarra Habchi <HabchiSarra>`.

- |Enhancement| The parameter `normalize` was added to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indent?

@jnothman
Copy link
Member

jnothman commented Nov 20, 2019

Looks inconsistent:
image

Do not need separate entry for this enh to a new feature:
image

@adrinjalali
Copy link
Member Author

Do you want some of those entries removed @jnothman ? The enhancement is a new one compared to previous release.

@jnothman
Copy link
Member

I mean the KNNImputer.add_indicator ENH does not need to be there if KNNImputer is being released now.

@adrinjalali adrinjalali merged commit 4f97fac into scikit-learn:master Nov 25, 2019
@adrinjalali adrinjalali deleted the cleanup/whats_new branch November 25, 2019 10:40
adrinjalali added a commit to adrinjalali/scikit-learn that referenced this pull request Nov 25, 2019
* whats_new cleanup

* fix indent

* reorder hgbt ones

* add Guillaume to contributors and remove unnecessary entry
jnothman pushed a commit that referenced this pull request Nov 28, 2019
* whats_new cleanup

* fix indent

* reorder hgbt ones

* add Guillaume to contributors and remove unnecessary entry
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
* whats_new cleanup

* fix indent

* reorder hgbt ones

* add Guillaume to contributors and remove unnecessary entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants