[MRG] Fix FutureWarning in plot_partial_dependence_visualization_api.py #16256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… well as small linting issue
ogrisel
approved these changes
Jan 29, 2020
rth
approved these changes
Jan 29, 2020
NicolasHug
reviewed
Jan 29, 2020
|
@NicolasHug thank you for the hint. I hope it's good now! |
|
Thanks @ksslng! |
ksslng
deleted the
fix-future-warning-in-example-plot-partial-dependence-visualization-api
branch
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR fixes a Warning in of the examples of #14117.
Specifically
examples/plot_partial_dependence_visualization_api.py (FutureWarning).What does this implement/fix? Explain your changes.
Attribute classes_ in DecisionTreeRegressor has been moved to super class BaseDecisionTree and is deprecated. With version 0.24 it will be removed. With an isintance check a hasattr call is prevented and solves the warning, which can be removed in version 0.24.
Any other comments?
Removed also
from ..tree._tree import DTYPEas it's unused and causes a linting complain.