Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC plot voting regression now uses diabetes dataset #16387

Merged

Conversation

maikia
Copy link
Contributor

@maikia maikia commented Feb 5, 2020

Reference Issues/PRs

towards #16155
It changes the boston dataset for diabetes dataset and adds some explanations to the example

What does this implement/fix? Explain your changes.

Any other comments?

@maikia maikia changed the title plot voting regresson now uses diabetes dataset plot voting regression now uses diabetes dataset Feb 6, 2020
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, but the rendered version has failed to have the structures you want to have. I think it has to do with the line length and characters used around the headers (https://92618-843222-gh.circle-artifacts.com/0/doc/auto_examples/ensemble/plot_voting_regressor.html)

examples/ensemble/plot_voting_regressor.py Outdated Show resolved Hide resolved
examples/ensemble/plot_voting_regressor.py Outdated Show resolved Hide resolved
@maikia maikia requested review from adrinjalali and rth and removed request for rth February 6, 2020 11:44
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maikia

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @maikia !

examples/ensemble/plot_voting_regressor.py Outdated Show resolved Hide resolved
examples/ensemble/plot_voting_regressor.py Show resolved Hide resolved
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maikia !

@thomasjpfan thomasjpfan changed the title plot voting regression now uses diabetes dataset DOC plot voting regression now uses diabetes dataset Feb 18, 2020
@thomasjpfan thomasjpfan merged commit 3e92edb into scikit-learn:master Feb 18, 2020
@maikia maikia deleted the boston_exchange_eg_plot_voting_regresson branch February 19, 2020 09:21
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants