Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sklearn logger default StreamHandler #16451

Merged
merged 5 commits into from May 4, 2020
Merged

Remove sklearn logger default StreamHandler #16451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
555e6fd
Remove sklearn logger default StreamHandler
cdeil Feb 16, 2020
46d8ebb
Merge remote-tracking branch 'upstream/master' into pr/16451
thomasjpfan Apr 29, 2020
dda7baa
DOC Adds whats_new
thomasjpfan Apr 29, 2020
df2db8e
CLN Address comments
thomasjpfan Apr 29, 2020
ff2ee13
MNT Remove setLevel
thomasjpfan May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/whats_new/v0.23.rst
View file
Open in desktop
Expand Up @@ -187,6 +187,12 @@ Changelog
`ValueError` for arguments `n_classes < 1` OR `length < 1`.
:pr:`16006` by :user:`Rushabh Vasani <rushabh-v>`.

- |API| The `StreamHandler` was removed from `sklearn.logger` to avoid
double logging of messages in common cases where a hander is attached
to the root logger, and to follow the Python logging documentation
recommendation for libraries to leave the log message handling to
users and application code. :pr:`16451` by :user:`Christoph Deil <cdeil>`.

:mod:`sklearn.decomposition`
............................

Expand Down
2 changes: 0 additions & 2 deletions sklearn/__init__.py
View file
Open in desktop
Expand Up @@ -19,8 +19,6 @@
from ._config import get_config, set_config, config_context

logger = logging.getLogger(__name__)
logger.addHandler(logging.StreamHandler())
logger.setLevel(logging.INFO)


# PEP0440 compatible formatted version, see:
Expand Down