New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added LinearOperator support in safe_sparse_dot() #16463
Open
PavelStishenko
wants to merge
13
commits into
scikit-learn:main
Choose a base branch
from
PavelStishenko:rand_svd_linop
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
41af221
added LinearOperator support in safe_sparse_dot()
f2a870e
Merge remote-tracking branch 'upstream/master' into rand_svd_linop
ebe8993
Added test for safe_sparse_dot(array, LinearOperator) and safe_sparse…
2fdd447
fix for flake8 compliance
3c1ecfa
make test work with old scipy
a04957e
set minimal scipy version for test
367ef98
use testing class for LiearOperator stub
5c11cb5
fixed lint errors
81aaebe
added explicit _transpose in TestingLinearOperator for compatibility …
8c61f0b
added test for randomized_svd with LinearOperator
0b0cef1
removed unnecessary method from TestingLinearOperator
8d06262
Renamed TestingLinearOperator to CustomLinearOperator for consistency…
c8e4e6c
Merge branch 'master' into rand_svd_linop
PavelStishenko File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are still failing. Also please add a test for
randomized_svd
on a LinearOperator.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The test added